Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DH): Link detection with unknown mime type #689

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

Angi-Kinas
Copy link
Collaborator

The link detection of a file format is now working even if the mime type is unknown

image

@Angi-Kinas Angi-Kinas added bug Something isn't working backport 2.0.x labels Nov 14, 2023
Copy link
Contributor

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search, util-shared, ui-widgets, feature-editor, ui-inputs,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 82.281% (-4.4%) from 86.643%
when pulling 50fd05e on DH-fix-i18n-failure
into 295eda8 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, @Angi-Kinas!

@Angi-Kinas Angi-Kinas merged commit 0cd989d into main Nov 14, 2023
7 checks passed
@Angi-Kinas Angi-Kinas deleted the DH-fix-i18n-failure branch November 14, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants