-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DH/Improve navigation button style #678
Conversation
Affected libs:
|
Maybe we could also leverage https://developer.mozilla.org/en-US/docs/Web/CSS/mix-blend-mode to make sure that buttons on top of any background are visible? |
There's also this which can be very useful: https://developer.mozilla.org/en-US/docs/Web/CSS/backdrop-filter Wide spread support is still quite fresh but e.g. blurring the backdrop of an element is a great effect for readability. |
@jahow Thanks for the suggestions! Last commit adds a shadow (it couldnt render in first commit) + the best Backdrop-filter also looks interesting, but I don't think we can keep the shadow if we use this (both together look weird IMO). Having a shadow is quite important in case of very light/white backgrounds. What do you think? |
Yes that's true. |
libs/ui/inputs/src/lib/navigation-button/navigation-button.component.html
Outdated
Show resolved
Hide resolved
Definitely backdrop-filter is great, it's what is used in Felt for the popups over the map, and the rendering is way better than just transparent. |
BTW, if anyone could animate the back to search button with a transition, it will be a nice 🎁 |
Description
This PR addresses the request to have a return button (in record page) that is easier to find. Some users struggle to find the current return button with a complex background image :
After consulting Lucile it was decided to invert the button style, and have a white and transparent background and the text in back + a shadow.