-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor]: Search in the whole catalog from any dashboard #1064
Conversation
Affected libs: ``,
|
📷 Screenshots are here! |
c2002b2
to
3a5b09c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cmoinier ! It works really well. I just saw some issues related to the search filters I've merged. I'll take a look at this. => Should now be fixed in #1065
Regarding the code, I left some comments for things I think we should try to improve.
Thanks also for adding back the search to the draft page. We might still get rid of one of the gray separator bars under the search here and maybe move the title up? I can't find the mockups for it.
apps/metadata-editor/src/app/records/all-records/all-records.component.ts
Outdated
Show resolved
Hide resolved
apps/metadata-editor/src/app/records/all-records/all-records.component.ts
Show resolved
Hide resolved
apps/metadata-editor/src/app/records/my-records/my-records.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/search/src/lib/fuzzy-search/fuzzy-search.component.ts
Outdated
Show resolved
Hide resolved
3a5b09c
to
90f9bdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmoinier I let you have a final look on this. From my side PR is good to merge (besides the e2e tests that keep staying red).
8a375d6
to
737e2bf
Compare
Description
This PR makes sure the search through the search header is done throughout the whole catalog, from any dashboard. For instance, the user can find records that they don't own if they start a search from "My records" dashboard.
It also clarifies the search state process, to make sure the states for "myRecords" and "allRecords" stay distinct and are not reinitialized at every render.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label