Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor]: Search in the whole catalog from any dashboard #1064

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Dec 12, 2024

Description

This PR makes sure the search through the search header is done throughout the whole catalog, from any dashboard. For instance, the user can find records that they don't own if they start a search from "My records" dashboard.
It also clarifies the search state process, to make sure the states for "myRecords" and "allRecords" stay distinct and are not reinitialized at every render.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Affected libs: ``,
Affected apps: metadata-editor,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 84.438% (-0.2%) from 84.621%
when pulling 737e2bf on ME-search-catalog-any-dashboard
into d9a09c3 on main.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

📷 Screenshots are here!

@cmoinier cmoinier force-pushed the ME-search-catalog-any-dashboard branch from c2002b2 to 3a5b09c Compare December 13, 2024 09:55
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmoinier ! It works really well. I just saw some issues related to the search filters I've merged. I'll take a look at this. => Should now be fixed in #1065

Regarding the code, I left some comments for things I think we should try to improve.

Thanks also for adding back the search to the draft page. We might still get rid of one of the gray separator bars under the search here and maybe move the title up? I can't find the mockups for it.

image

@cmoinier cmoinier force-pushed the ME-search-catalog-any-dashboard branch from 3a5b09c to 90f9bdc Compare December 19, 2024 14:40
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmoinier I let you have a final look on this. From my side PR is good to merge (besides the e2e tests that keep staying red).

@tkohr tkohr force-pushed the ME-search-catalog-any-dashboard branch from 8a375d6 to 737e2bf Compare December 20, 2024 14:42
@cmoinier cmoinier merged commit 8c98ae0 into main Dec 21, 2024
14 checks passed
@cmoinier cmoinier deleted the ME-search-catalog-any-dashboard branch December 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants