Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality score keyword item wasn't checked #1054

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Dec 6, 2024

Description

This PR adds allKeywords to global search in order to have the quality score fully checked.

Screenshots

This was resulting of having a quality score of 100% but keywords item unchecked :
image

=>

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews

This work is sponsored by INRAE.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Affected libs: feature-search, feature-router, feature-map, feature-record,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Dec 6, 2024

Coverage Status

coverage: 85.24% (+1.8%) from 83.419%
when pulling 1381f56 on fix-quality-score-keyword-item
into a731fc6 on main.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

📷 Screenshots are here!

@jahow
Copy link
Collaborator

jahow commented Dec 6, 2024

How come the tag field is not enough? Doesn't it contain all keywords already? I'd be interested to see a record where this happens, thanks :)

@f-necas
Copy link
Collaborator Author

f-necas commented Dec 6, 2024

It seems that it doesn't work with tag field. Neither tags

 'qualityScore',
  'tag',
]

As I understand, it seems that keywords are only mapped from allKeywords : https://github.com/geonetwork/geonetwork-ui/blob/main/libs/api/metadata-converter/src/lib/gn4/gn4.field.mapper.ts#L210

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, indeed this commit is reading the keywords from allKeywords instead of tag: 92a8747

Could you then please remove the tag field from the FIELDS_SUMMARY list? thank you!

@f-necas
Copy link
Collaborator Author

f-necas commented Dec 6, 2024

Done :)

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jahow jahow merged commit a26f16e into main Dec 6, 2024
13 checks passed
@jahow jahow deleted the fix-quality-score-keyword-item branch December 6, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants