-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality score keyword item wasn't checked #1054
Conversation
Affected libs:
|
📷 Screenshots are here! |
How come the |
It seems that it doesn't work with tag field. Neither
As I understand, it seems that keywords are only mapped from allKeywords : https://github.com/geonetwork/geonetwork-ui/blob/main/libs/api/metadata-converter/src/lib/gn4/gn4.field.mapper.ts#L210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, indeed this commit is reading the keywords from allKeywords
instead of tag
: 92a8747
Could you then please remove the tag
field from the FIELDS_SUMMARY
list? thank you!
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
This PR adds allKeywords to global search in order to have the quality score fully checked.
Screenshots
This was resulting of having a quality score of 100% but keywords item unchecked :
=>
Quality Assurance Checklist
This work is sponsored by INRAE.