-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Display and Edit Resource Creation date #1053
Conversation
Affected libs:
|
📷 Screenshots are here! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ronitjadhav for adding this field!
The code looks good and it works as expected 🚀
I have some minor comments, you can decide if you want to change something.
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.html
Outdated
Show resolved
Hide resolved
@@ -66,6 +66,12 @@ | |||
(valueChange)="valueChange.emit($event)" | |||
></gn-ui-form-field-overviews> | |||
</ng-container> | |||
<ng-container *ngSwitchCase="'resourceCreated'"> | |||
<gn-ui-form-field-date-updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not have to be changed, but I was wondering if the name of this component is too specific as it serves date updated and date created now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also thinking of the same.
I guess I can change it to gn-ui-form-field-date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Description
This pull request adds the ability to display and edit the "Resource Created" date of the resource in the "About the resource" section.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label