Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Display and Edit Resource Creation date #1053

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

ronitjadhav
Copy link
Collaborator

@ronitjadhav ronitjadhav commented Dec 3, 2024

Description

This pull request adds the ability to display and edit the "Resource Created" date of the resource in the "About the resource" section.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@ronitjadhav ronitjadhav changed the title Display and Edit Resource Creation date [Editor] Display and Edit Resource Creation date Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Affected libs: common-fixtures, api-metadata-converter, feature-search, feature-router, feature-map, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, feature-dataviz, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Dec 3, 2024

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Dec 3, 2024

Coverage Status

coverage: 83.736% (+0.3%) from 83.419%
when pulling e06d590 on resource-dates
into a731fc6 on main.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ronitjadhav for adding this field!

The code looks good and it works as expected 🚀

I have some minor comments, you can decide if you want to change something.

@@ -66,6 +66,12 @@
(valueChange)="valueChange.emit($event)"
></gn-ui-form-field-overviews>
</ng-container>
<ng-container *ngSwitchCase="'resourceCreated'">
<gn-ui-form-field-date-updated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not have to be changed, but I was wondering if the name of this component is too specific as it serves date updated and date created now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also thinking of the same.
I guess I can change it to gn-ui-form-field-date

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ronitjadhav ronitjadhav merged commit 48c95d3 into main Dec 9, 2024
13 checks passed
@ronitjadhav ronitjadhav deleted the resource-dates branch December 9, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants