-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Support resource identifier edition #1045
Conversation
@@ -744,6 +745,30 @@ describe('read parts', () => { | |||
]) | |||
}) | |||
}) | |||
|
|||
describe('read resource identifier', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove this test to avoid too many tests as this is a simple field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be removed, and actually I'm not sure it's actually working as intended (as the provided XML does not include the full hierarchy i.e. identification block, citation block...)
identifier edition feat(editor): add field for resource identifier edition
b207bdb
to
9edd07f
Compare
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it works perfectly! I feel like the current situation with the dropdown styling is a bit awkward but it stills renders well so we can keep it like that :) Please take a loot at my comments and feel free to merge when you've addressed them!
}" | ||
[ngModel]="value" | ||
(ngModelChange)="valueChange.emit($event)" | ||
class="gn-ui-text-input border-gray-300 hover:border-main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be added I think, the gn-ui-text-input class already handles border color and this will be the same on all input fields
Description
This PR introduces a new resource identifier input field. This field refers to the resource not the metadata.
Also the
FormFieldSimpleComponent
was simplified so it is able to emit values.Additionally I adapted some styles to the
DropdownSelectorComponent
to make the fields look more similar.Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label