Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Support resource identifier edition #1045

Merged
merged 10 commits into from
Nov 25, 2024

Conversation

Angi-Kinas
Copy link
Collaborator

@Angi-Kinas Angi-Kinas commented Nov 19, 2024

Description

This PR introduces a new resource identifier input field. This field refers to the resource not the metadata.
Also the FormFieldSimpleComponent was simplified so it is able to emit values.

Additionally I adapted some styles to the DropdownSelectorComponent to make the fields look more similar.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@@ -744,6 +745,30 @@ describe('read parts', () => {
])
})
})

describe('read resource identifier', () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove this test to avoid too many tests as this is a simple field?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed, and actually I'm not sure it's actually working as intended (as the provided XML does not include the full hierarchy i.e. identification block, citation block...)

@Angi-Kinas Angi-Kinas force-pushed the ME-support-resource-identifier-edition branch from b207bdb to 9edd07f Compare November 19, 2024 15:21
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Affected libs: api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, common-domain, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, metadata-converter, datahub, demo, webcomponents, search, map-viewer, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Nov 19, 2024

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it works perfectly! I feel like the current situation with the dropdown styling is a bit awkward but it stills renders well so we can keep it like that :) Please take a loot at my comments and feel free to merge when you've addressed them!

}"
[ngModel]="value"
(ngModelChange)="valueChange.emit($event)"
class="gn-ui-text-input border-gray-300 hover:border-main"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be added I think, the gn-ui-text-input class already handles border color and this will be the same on all input fields

@coveralls
Copy link

Coverage Status

coverage: 83.611% (-1.2%) from 84.803%
when pulling 5b948e2 on ME-support-resource-identifier-edition
into fdac73d on main.

@Angi-Kinas Angi-Kinas merged commit d6fa0bf into main Nov 25, 2024
13 checks passed
@Angi-Kinas Angi-Kinas deleted the ME-support-resource-identifier-edition branch November 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants