-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub / fix some layout issues #1044
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jahow for these visual improvements 🎉
The CI failed and I think it might be because one variable is not set in the .ts file.
Otherwise looking good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can go ahead when the CI is green :-)
thank you! |
Description
This PR fixes the following issues:
the language switcher now shows up in the same place on the record page and home page:
the "map" button in the preview section of the record page now has a correct size:
the layout of the search filters block now correctly renders if the sort-by field is too big:
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label