Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub / fix some layout issues #1044

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Datahub / fix some layout issues #1044

merged 3 commits into from
Nov 19, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Nov 19, 2024

Description

This PR fixes the following issues:

  • the language switcher now shows up in the same place on the record page and home page:
    image

  • the "map" button in the preview section of the record page now has a correct size:
    image

  • the layout of the search filters block now correctly renders if the sort-by field is too big:
    image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

Affected libs: feature-record, feature-router, ui-catalog, feature-catalog,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Nov 19, 2024

📷 Screenshots are here!

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jahow for these visual improvements 🎉

The CI failed and I think it might be because one variable is not set in the .ts file.
Otherwise looking good 👍

@coveralls
Copy link

Coverage Status

coverage: 85.714% (+1.4%) from 84.36%
when pulling 1abd2ec on misc-datahub-layout-issues
into 68624e7 on main.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go ahead when the CI is green :-)

@jahow jahow merged commit a2b8f0d into main Nov 19, 2024
13 checks passed
@jahow jahow deleted the misc-datahub-layout-issues branch November 19, 2024 13:07
@jahow
Copy link
Collaborator Author

jahow commented Nov 19, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants