Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor]: Hide open data toggle #1033

Merged
merged 3 commits into from
Nov 5, 2024
Merged

[Editor]: Hide open data toggle #1033

merged 3 commits into from
Nov 5, 2024

Conversation

cmoinier
Copy link
Collaborator

Description

This PR hides the open data toggle in the editor, and thus makes sure that the licenses list is always displayed.
The affected lines were only commented out, so that it'll be easier to understand once we will start adapting the toggle to the constraints logic.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Affected libs: feature-editor,
Affected apps: metadata-editor, datafeeder, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 29, 2024

📷 Screenshots are here!

@cmoinier cmoinier force-pushed the remove-open-data-toggle branch from 13f7d03 to d081b70 Compare October 29, 2024 15:50
@cmoinier cmoinier force-pushed the remove-open-data-toggle branch from d081b70 to 7a38740 Compare October 29, 2024 16:12
@coveralls
Copy link

coveralls commented Oct 29, 2024

Coverage Status

coverage: 80.717% (-3.2%) from 83.88%
when pulling 16b03ad on remove-open-data-toggle
into 868939e on main.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier for disabling the Open Data toggle (for now).

It looks good already, I just had one note.

@cmoinier cmoinier merged commit e8eb1e1 into main Nov 5, 2024
13 checks passed
@cmoinier cmoinier deleted the remove-open-data-toggle branch November 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants