Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ogc-client #1031

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore: update ogc-client #1031

merged 3 commits into from
Oct 29, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Oct 28, 2024

Description

This PR updates ogc-client to the latest dev version. Also fixes E2E tests for datahub and editor (hopefully getting rid of the "disabled element" recurring error).

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Affected libs: database-dump, data-access-datafeeder, api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, feature-notifications, util-data-fetcher, util-app-config, common-fixtures, ui-elements, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, data-access-gn4, common-domain, ui-dataviz, util-i18n,
Affected apps: datahub, datafeeder, metadata-converter, metadata-editor, demo, webcomponents, search, map-viewer, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 28, 2024

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Oct 28, 2024

Coverage Status

coverage: 83.88% (+0.6%) from 83.264%
when pulling c51362e on update-ogc-client
into 7e43a35 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jahow, in particular for the e2e test 🤩 ! The other changes are related to the ogc-client update, I guess. Looking at the datahub map, it works as expected!

@jahow jahow force-pushed the update-ogc-client branch from 79f6d58 to b8d0dc5 Compare October 29, 2024 17:45
jahow added 3 commits October 29, 2024 19:20
ogc-client now uses the proper WFS download urls (as advertised in the capabilities
document) so they need to be adjusted in the e2e tests.
@jahow jahow force-pushed the update-ogc-client branch from b8d0dc5 to c51362e Compare October 29, 2024 18:21
@jahow jahow merged commit a03dd41 into main Oct 29, 2024
13 checks passed
@jahow jahow deleted the update-ogc-client branch October 29, 2024 20:50
@jahow
Copy link
Collaborator Author

jahow commented Oct 29, 2024

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants