[Editor]: Fix cleanup attachments function

[cmoinier]

Description

This PR fixes a wrong behavior in the editor's form, where the cleanup attachment function deletes the newly added attachments (eg : if an image is added, then the record saved, and then reloaded, the new image would be deleted).

This was because of a mapping that was not working : the names of the saved attachments were supposed to match the names of the new attachments, and the mapping was not taking into account that the name object had language keys in it, thus returning "undefined" for all attachment's names.

Quality Assurance Checklist

• Commit history is devoid of any merge commits and readable to facilitate reviews
• If new logic ⚙️ is introduced: unit tests were added
• If new user stories 🤏 are introduced: E2E tests were added
• If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
• If breaking changes 🪚 are introduced: add the breaking change label
• If bugs 🐞 are fixed: add the backport <release branch> label
• The documentation website 📚 has received the love it deserves

[github-actions]

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-editor, feature-auth,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder,

• 🚀 Build and deploy storybook and demo on GitHub Pages
• 📦 Build and push affected docker images

[github-actions]

📷 Screenshots are here!

[coveralls]

coverage: 84.386% (+0.5%) from 83.868%
when pulling 506684a on fix-attachments-cleanup
into 8665bf5 on main.

[jahow]

Thank you! I wonder if the original mapping wasn't done against another version of GN? It's possible that the API response differs (e.g. with localized names) between 4.2.5 and 4.4.0 for instance.

Maybe having a test of this in an e2e test would make sure this works against all version; essentially we just need to test that once an image has been uploaded and the record saved the image still shows up correctly (i.e. it has not been cleaned up).

[cmoinier]

Thank you! I wonder if the original mapping wasn't done against another version of GN? It's possible that the API response differs (e.g. with localized names) between 4.2.5 and 4.4.0 for instance.

Maybe having a test of this in an e2e test would make sure this works against all version; essentially we just need to test that once an image has been uploaded and the record saved the image still shows up correctly (i.e. it has not been cleaned up).

@jahow I think this e2e covers it already, and it passed with all versions on the CI 🙂 [](

geonetwork-ui/apps/metadata-editor-e2e/src/e2e/edit.cy.ts

Line 183 in 8665bf5

it('adds overviews', () => {

)

[jahow]

Thank you! I wonder if the original mapping wasn't done against another version of GN? It's possible that the API response differs (e.g. with localized names) between 4.2.5 and 4.4.0 for instance.
Maybe having a test of this in an e2e test would make sure this works against all version; essentially we just need to test that once an image has been uploaded and the record saved the image still shows up correctly (i.e. it has not been cleaned up).

@jahow I think this e2e covers it already, and it passed with all versions on the CI 🙂 [](

geonetwork-ui/apps/metadata-editor-e2e/src/e2e/edit.cy.ts

Line 183 in 8665bf5

it('adds overviews', () => {

)

OK so there's already an e2e test, but the test would not fail if the underlying image file ends up being deleted. Could you try and expand a bit the test to make sure that the url of the image does not end up in a 404? thanks!

[jahow]

Thanks!