Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME: drop publishing support below 4.2.5 #1018

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

LHBruneton-C2C
Copy link
Collaborator

Description

This PR prevents publication on GN versions below 4.2.5. Instead, an error message is shown.

image

To test locally, the GN version in the docker composition .env file must be switched back to a version below 4.2.5.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-editor, feature-auth, common-domain, api-metadata-converter, ui-search, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 15, 2024

📷 Screenshots are here!

@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/drop-publishing-support-below-4.2.5 branch from a5c3e44 to 6f1a593 Compare October 16, 2024 07:14
@coveralls
Copy link

Coverage Status

coverage: 83.261% (-0.2%) from 83.434%
when pulling 6f1a593 on ME/drop-publishing-support-below-4.2.5
into 822d2a4 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LHBruneton-C2C ! PR LGTM and the popups work as expected on versions larger/equal and lower 4.2.5.

@LHBruneton-C2C LHBruneton-C2C merged commit 2ade901 into main Oct 17, 2024
13 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/drop-publishing-support-below-4.2.5 branch October 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants