Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ME]: Add search filters #1015

Merged
merged 6 commits into from
Oct 18, 2024
Merged

[ME]: Add search filters #1015

merged 6 commits into from
Oct 18, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Oct 10, 2024

Description

This PR introduces a new search-filters.component for the md-editor app. It is displayed with a first filter allowing to filter on editor/user on the allRecords list. The component is also displayed on the myRecords list, but empty for now as the editor filter does not make much sense here.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Affected libs: feature-search, feature-router, feature-map, feature-dataviz, feature-record, ui-inputs, feature-editor, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-layout,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 10, 2024

📷 Screenshots are here!

with a first filter to filter on editor/user
@tkohr tkohr force-pushed the me-search-filters branch from 1596423 to e3baf86 Compare October 10, 2024 14:47
@tkohr tkohr marked this pull request as ready for review October 15, 2024 13:05
@coveralls
Copy link

coveralls commented Oct 15, 2024

Coverage Status

coverage: 81.047% (-2.4%) from 83.434%
when pulling c31e2cf on me-search-filters
into 822d2a4 on main.

@tkohr tkohr merged commit 7b660c1 into main Oct 18, 2024
13 checks passed
@tkohr tkohr deleted the me-search-filters branch October 18, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants