Metadata Editor: redirect to login URL if accessing the editor as anonymous user #1006
Conversation
|
Affected libs: ``,
|
| }, | ||
| ], | ||
| }, | ||
| { path: 'sign-in', component: SignInPageComponent }, |
There was a problem hiding this comment.
this route was removed as it was obviously not needed anyway
| component: DashboardPageComponent, | ||
| outlet: 'primary', | ||
| path: '', | ||
| canActivate: [AuthGuardService], | ||
| children: [ |
There was a problem hiding this comment.
Adding a root route ( 🤔 ) makes it easier to apply the same guard to all routes
|
📷 Screenshots are here! |
| it('redirects to the login page', () => { | ||
| cy.url().should( | ||
| 'include', | ||
| '/catalog.signin?redirect=http://localhost:4200/catalog/search' |
There was a problem hiding this comment.
Out of curiosity, where does this redirect value come from? The referer? It's often needed to be redirected after successful login, but I don't see it written in our code.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for this improvement.
There is still one corner case when the authentication might fail, when the user is already wrongly connected (XSFR cookie set on the wrong path from the legacy UI), and the redirection is not activated then.
Otherwise, all good !
jahow
force-pushed
the
me-redirect-to-login
branch
from
0bba5e3 to
c16c6bc
Compare
jahow
force-pushed
the
me-redirect-to-login
branch
from
c16c6bc to
c95043b
Compare
Description
This PR adds a common route guard for all routes in the ME app.
Also removed an unused component.
Architectural changes
none
Quality Assurance Checklist
breaking changelabelbackport <release branch>label