feat(notifications-service): log errors in console when displaying er…

…ror notifications
geonetwork · Dec 11, 2024 · f8de49c · f8de49c
1 parent af826c8
commit f8de49c
Show file tree

Hide file tree

Showing 9 changed files with 137 additions and 97 deletions.
diff --git a/apps/metadata-editor/src/app/duplicate-record.resolver.ts b/apps/metadata-editor/src/app/duplicate-record.resolver.ts
@@ -23,18 +23,22 @@ export class DuplicateRecordResolver {
       .openRecordForDuplication(route.paramMap.get('uuid'))
       .pipe(
         catchError((error) => {
-          this.notificationsService.showNotification({
-            type: 'error',
-            title: this.translateService.instant(
-              'editor.record.loadError.title'
-            ),
-            text: `${this.translateService.instant(
-              'editor.record.loadError.body'
-            )} ${error.message}`,
-            closeMessage: this.translateService.instant(
-              'editor.record.loadError.closeMessage'
-            ),
-          })
+          this.notificationsService.showNotification(
+            {
+              type: 'error',
+              title: this.translateService.instant(
+                'editor.record.loadError.title'
+              ),
+              text: `${this.translateService.instant(
+                'editor.record.loadError.body'
+              )} ${error.message}`,
+              closeMessage: this.translateService.instant(
+                'editor.record.loadError.closeMessage'
+              ),
+            },
+            undefined,
+            error
+          )
           return EMPTY
         })
       )

diff --git a/apps/metadata-editor/src/app/edit-record.resolver.ts b/apps/metadata-editor/src/app/edit-record.resolver.ts
@@ -23,18 +23,22 @@ export class EditRecordResolver {
       .openRecordForEdition(route.paramMap.get('uuid'))
       .pipe(
         catchError((error) => {
-          this.notificationsService.showNotification({
-            type: 'error',
-            title: this.translateService.instant(
-              'editor.record.loadError.title'
-            ),
-            text: `${this.translateService.instant(
-              'editor.record.loadError.body'
-            )} ${error.message}`,
-            closeMessage: this.translateService.instant(
-              'editor.record.loadError.closeMessage'
-            ),
-          })
+          this.notificationsService.showNotification(
+            {
+              type: 'error',
+              title: this.translateService.instant(
+                'editor.record.loadError.title'
+              ),
+              text: `${this.translateService.instant(
+                'editor.record.loadError.body'
+              )} ${error.message}`,
+              closeMessage: this.translateService.instant(
+                'editor.record.loadError.closeMessage'
+              ),
+            },
+            undefined,
+            error
+          )
           return EMPTY
         })
       )

diff --git a/apps/metadata-editor/src/app/edit/edit-page.component.ts b/apps/metadata-editor/src/app/edit/edit-page.component.ts
@@ -83,32 +83,40 @@ export class EditPageComponent implements OnInit, OnDestroy {
     this.subscription.add(
       this.facade.saveError$.subscribe((error) => {
         if (error instanceof PublicationVersionError) {
-          this.notificationsService.showNotification({
-            type: 'error',
-            title: this.translateService.instant(
-              'editor.record.publishVersionError.title'
-            ),
-            text: this.translateService.instant(
-              'editor.record.publishVersionError.body',
-              { currentVersion: error.detectedApiVersion }
-            ),
-            closeMessage: this.translateService.instant(
-              'editor.record.publishVersionError.closeMessage'
-            ),
-          })
+          this.notificationsService.showNotification(
+            {
+              type: 'error',
+              title: this.translateService.instant(
+                'editor.record.publishVersionError.title'
+              ),
+              text: this.translateService.instant(
+                'editor.record.publishVersionError.body',
+                { currentVersion: error.detectedApiVersion }
+              ),
+              closeMessage: this.translateService.instant(
+                'editor.record.publishVersionError.closeMessage'
+              ),
+            },
+            undefined,
+            error
+          )
         } else {
-          this.notificationsService.showNotification({
-            type: 'error',
-            title: this.translateService.instant(
-              'editor.record.publishError.title'
-            ),
-            text: `${this.translateService.instant(
-              'editor.record.publishError.body'
-            )} ${error.message}`,
-            closeMessage: this.translateService.instant(
-              'editor.record.publishError.closeMessage'
-            ),
-          })
+          this.notificationsService.showNotification(
+            {
+              type: 'error',
+              title: this.translateService.instant(
+                'editor.record.publishError.title'
+              ),
+              text: `${this.translateService.instant(
+                'editor.record.publishError.body'
+              )} ${error.message}`,
+              closeMessage: this.translateService.instant(
+                'editor.record.publishError.closeMessage'
+              ),
+            },
+            undefined,
+            error
+          )
         }
       })
     )

diff --git a/libs/feature/editor/src/lib/components/import-record/import-record.component.ts b/libs/feature/editor/src/lib/components/import-record/import-record.component.ts
@@ -142,7 +142,8 @@ export class ImportRecordComponent {
               'editor.record.importFromExternalFile.failure.body'
             )} ${error.message ?? ''}`,
           },
-          2500
+          2500,
+          error
         )
         this.isRecordImportInProgress = false
         this.cdr.markForCheck()

diff --git a/...form-field/form-field-online-link-resources/form-field-online-link-resources.component.ts b/...form-field/form-field-online-link-resources/form-field-online-link-resources.component.ts
@@ -137,18 +137,22 @@ export class FormFieldOnlineLinkResourcesComponent {
   private handleError(error: Error) {
     this.uploadProgress = undefined
     this.cd.detectChanges()
-    this.notificationsService.showNotification({
-      type: 'error',
-      title: this.translateService.instant(
-        'editor.record.onlineResourceError.title'
-      ),
-      text: `${this.translateService.instant(
-        'editor.record.onlineResourceError.body'
-      )} ${error.message}`,
-      closeMessage: this.translateService.instant(
-        'editor.record.onlineResourceError.closeMessage'
-      ),
-    })
+    this.notificationsService.showNotification(
+      {
+        type: 'error',
+        title: this.translateService.instant(
+          'editor.record.onlineResourceError.title'
+        ),
+        text: `${this.translateService.instant(
+          'editor.record.onlineResourceError.body'
+        )} ${error.message}`,
+        closeMessage: this.translateService.instant(
+          'editor.record.onlineResourceError.closeMessage'
+        ),
+      },
+      undefined,
+      error
+    )
   }
 
   private openEditDialog(resource: OnlineLinkResource, index: number) {

diff --git a/...cord-form/form-field/form-field-online-resources/form-field-online-resources.component.ts b/...cord-form/form-field/form-field-online-resources/form-field-online-resources.component.ts
@@ -192,18 +192,22 @@ export class FormFieldOnlineResourcesComponent {
 
   private handleError(error: Error) {
     this.uploadProgress = undefined
-    this.notificationsService.showNotification({
-      type: 'error',
-      title: this.translateService.instant(
-        'editor.record.onlineResourceError.title'
-      ),
-      text: `${this.translateService.instant(
-        'editor.record.onlineResourceError.body'
-      )} ${error.message}`,
-      closeMessage: this.translateService.instant(
-        'editor.record.onlineResourceError.closeMessage'
-      ),
-    })
+    this.notificationsService.showNotification(
+      {
+        type: 'error',
+        title: this.translateService.instant(
+          'editor.record.onlineResourceError.title'
+        ),
+        text: `${this.translateService.instant(
+          'editor.record.onlineResourceError.body'
+        )} ${error.message}`,
+        closeMessage: this.translateService.instant(
+          'editor.record.onlineResourceError.closeMessage'
+        ),
+      },
+      undefined,
+      error
+    )
   }
 
   private openEditDialog(resource: OnlineNotLinkResource, index: number) {

diff --git a/.../components/record-form/form-field/form-field-overviews/form-field-overviews.component.ts b/.../components/record-form/form-field/form-field-overviews/form-field-overviews.component.ts
@@ -109,15 +109,21 @@ export class FormFieldOverviewsComponent {
   private handleError = (error: Error) => {
     this.uploadProgress = undefined
     this.cd.markForCheck()
-    this.notificationsService.showNotification({
-      type: 'error',
-      title: this.translateService.instant('editor.record.resourceError.title'),
-      text: `${this.translateService.instant(
-        'editor.record.resourceError.body'
-      )} ${error.message}`,
-      closeMessage: this.translateService.instant(
-        'editor.record.resourceError.closeMessage'
-      ),
-    })
+    this.notificationsService.showNotification(
+      {
+        type: 'error',
+        title: this.translateService.instant(
+          'editor.record.resourceError.title'
+        ),
+        text: `${this.translateService.instant(
+          'editor.record.resourceError.body'
+        )} ${error.message}`,
+        closeMessage: this.translateService.instant(
+          'editor.record.resourceError.closeMessage'
+        ),
+      },
+      undefined,
+      error
+    )
   }
 }
diff --git a/libs/feature/notifications/src/lib/notifications.service.ts b/libs/feature/notifications/src/lib/notifications.service.ts
@@ -10,7 +10,12 @@ type NotificationWithIdentity = NotificationContent & { id: number }
 export class NotificationsService {
   notifications$ = new BehaviorSubject<NotificationWithIdentity[]>([])
 
-  showNotification(content: NotificationContent, timeoutMs?: number) {
+  showNotification(
+    content: NotificationContent,
+    timeoutMs?: number,
+    error?: Error
+  ) {
+    error && console.error(error)
     const id = Math.floor(Math.random() * 1000000)
     this.notifications$.next([...this.notifications$.value, { ...content, id }])
     if (typeof timeoutMs === 'undefined') return

diff --git a/libs/feature/search/src/lib/results-table/results-table-container.component.ts b/libs/feature/search/src/lib/results-table/results-table-container.component.ts
@@ -79,18 +79,22 @@ export class ResultsTableContainerComponent implements OnDestroy {
           )
         },
         error: (error) => {
-          this.notificationsService.showNotification({
-            type: 'error',
-            title: this.translateService.instant(
-              'editor.record.deleteError.title'
-            ),
-            text: `${this.translateService.instant(
-              'editor.record.deleteError.body'
-            )} ${error}`,
-            closeMessage: this.translateService.instant(
-              'editor.record.deleteError.closeMessage'
-            ),
-          })
+          this.notificationsService.showNotification(
+            {
+              type: 'error',
+              title: this.translateService.instant(
+                'editor.record.deleteError.title'
+              ),
+              text: `${this.translateService.instant(
+                'editor.record.deleteError.body'
+              )} ${error}`,
+              closeMessage: this.translateService.instant(
+                'editor.record.deleteError.closeMessage'
+              ),
+            },
+            undefined,
+            error
+          )
         },
       })
     )