Merge pull request #299 from geonetwork/fix-downloads-block

Fix downloads block
geonetwork · Sep 5, 2022 · 66c435b · 66c435b
2 parents 9fb65e0 + 6879bb3
commit 66c435b
Show file tree

Hide file tree

Showing 9 changed files with 36 additions and 5 deletions.
diff --git a/libs/feature/record/src/lib/record-metadata/record-metadata.component.html b/libs/feature/record/src/lib/record-metadata/record-metadata.component.html
@@ -27,7 +27,8 @@
       <gn-ui-metadata-contact
         (contact)="onContactClick($event)"
         [metadata]="facade.metadata$ | async"
-      ></gn-ui-metadata-contact>
+      >
+      </gn-ui-metadata-contact>
       <gn-ui-metadata-catalog [sourceLabel]="sourceLabel$ | async">
       </gn-ui-metadata-catalog>
     </div>
@@ -89,10 +90,12 @@
   </div>
 </div>
 
-<div id="access" class="container-lg px-4 lg:mx-auto">
-  <div *ngIf="displayDownload$ | async">
-    <gn-ui-data-downloads class="block mt-5"></gn-ui-data-downloads>
-  </div>
+<div
+  id="access"
+  class="container-lg px-4 lg:mx-auto"
+  *ngIf="displayDownload$ | async"
+>
+  <gn-ui-data-downloads class="block mt-5"></gn-ui-data-downloads>
 </div>
 
 <div id="links" class="container-lg px-4 lg:mx-auto">

diff --git a/libs/ui/elements/src/lib/downloads-list/downloads-list.component.spec.ts b/libs/ui/elements/src/lib/downloads-list/downloads-list.component.spec.ts
@@ -80,6 +80,20 @@ describe('DownloadsListComponent', () => {
       expect(items.length).toBe(3)
     })
   })
+
+  describe('when a list of downloads is empty', () => {
+    let item: DebugElement
+
+    beforeEach(() => {
+      component.links = []
+      fixture.detectChanges()
+      item = de.query(By.directive(DownloadsListComponent))
+    })
+    it('should not display', () => {
+      expect(item).toBeNull()
+    })
+  })
+
   describe('when link format is unknown', () => {
     let items: DebugElement[]
 

diff --git a/translations/de.json b/translations/de.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "",
   "datahub.search.back": "",
   "datahub.search.filter.generatedByWfs": "",
+  "datahub.search.filter.all": "",
+  "datahub.search.filter.others": "",
   "dataset.error.http": "",
   "dataset.error.network": "",
   "dataset.error.parse": "",

diff --git a/translations/en.json b/translations/en.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "Indicators",
   "datahub.search.back": "Back to results",
   "datahub.search.filter.generatedByWfs": "generated by API (WFS)",
+  "datahub.search.filter.all": "All",
+  "datahub.search.filter.others": "Others",
   "dataset.error.http": "The data could not be loaded because of an HTTP error",
   "dataset.error.network": "The data could not be loaded because of a network error or CORS limitations",
   "dataset.error.parse": "The data was loaded but could not be parsed",

diff --git a/translations/es.json b/translations/es.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "",
   "datahub.search.back": "",
   "datahub.search.filter.generatedByWfs": "",
+  "datahub.search.filter.all": "",
+  "datahub.search.filter.others": "",
   "dataset.error.http": "",
   "dataset.error.network": "",
   "dataset.error.parse": "",

diff --git a/translations/fr.json b/translations/fr.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "Quelques chiffres",
   "datahub.search.back": "Retour aux résultats",
   "datahub.search.filter.generatedByWfs": "généré par API (WFS)",
+  "datahub.search.filter.all": "Tout",
+  "datahub.search.filter.others": "Autres",
   "dataset.error.http": "Le chargement des données a échoué en raison d'une erreur HTTP",
   "dataset.error.network": "Le chargement des données a échoué en raison d'une erreur réseau ou de limitations CORS",
   "dataset.error.parse": "Les données ont été chargées mais leur décodage a échoué",

diff --git a/translations/it.json b/translations/it.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "",
   "datahub.search.back": "",
   "datahub.search.filter.generatedByWfs": "name",
+  "datahub.search.filter.all": "",
+  "datahub.search.filter.others": "",
   "dataset.error.http": "",
   "dataset.error.network": "",
   "dataset.error.parse": "",

diff --git a/translations/nl.json b/translations/nl.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "",
   "datahub.search.back": "",
   "datahub.search.filter.generatedByWfs": "",
+  "datahub.search.filter.all": "",
+  "datahub.search.filter.others": "",
   "dataset.error.http": "",
   "dataset.error.network": "",
   "dataset.error.parse": "",

diff --git a/translations/pt.json b/translations/pt.json
@@ -86,6 +86,8 @@
   "datahub.news.figures": "",
   "datahub.search.back": "",
   "datahub.search.filter.generatedByWfs": "",
+  "datahub.search.filter.all": "",
+  "datahub.search.filter.others": "",
   "dataset.error.http": "",
   "dataset.error.network": "",
   "dataset.error.parse": "",