Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toolchain to autodetect jdk #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joachimnielandt
Copy link
Collaborator

@joachimnielandt joachimnielandt commented Jun 15, 2023

I had some trouble when building locally, as javac wasn't detected properly. Only after setting my OS-wide Java to v11 it built successfully. I remembered Geonetwork used toolchains though, which I added here as well. Does that make sense in this context?

Took the opportunity to tidy up some whitespace issues as well...

- is used to autodetect correct jdk
- mirrored the setup of geonetwork which seemed to work fine for me
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants