Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

georss - adding a simple endpoint accessible with a GET request #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

landryb
Copy link

@landryb landryb commented Mar 29, 2023

Afaict, georchestra/geonetwork-microservices@0953b7215 is the only meaningful src commit that was present in the geor-main branch of https://github.com/georchestra/geonetwork-microservices and not present in this upstream repo.

cf main...georchestra:geonetwork-microservices:geor-main

having this upstreamed would allow the georchestra project buildbot to start building the searching and ogc-api-records jars from the same repository, instead of providing a badly outdated jar on https://packages.georchestra.org/bot/wars/geonetwork-microservices/

cf georchestra/datadir#271, cc @pmauduit @jahow @fvanderbiest @fgravin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

landryb added a commit to georchestra/ansible that referenced this pull request Mar 30, 2023
the url points at a jar built from https://github.com/geonetwork/geonetwork-microservices/releases/tag/4.2.2
compatible with the geonetwork 4.2.2 shipped in georchestra.

when geonetwork/geonetwork-microservices#72 is merged and geonetwork is
upgraded to 4.2.3 we can point the georchestra CI at this upstream repo, until
now use this self-built jar..
landryb added a commit to georchestra/ansible that referenced this pull request Mar 30, 2023
the url points at a jar built from https://github.com/geonetwork/geonetwork-microservices/releases/tag/4.2.2
compatible with the geonetwork 4.2.2 shipped in georchestra.

when geonetwork/geonetwork-microservices#72 is merged and geonetwork is
upgraded to 4.2.3 we can point the georchestra CI at this upstream repo, until
now use this self-built jar..
@landryb
Copy link
Author

landryb commented Apr 26, 2023

@fgravin @pmauduit can this get reviewed/merged somehow ? thanks !


/**
* provides an API endpoint for a GeoRSS endpoint, also sorts the records
* by changeDate (descending), and limits the results to the first 10.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but iirc this was developed before ogc-api-records was able to provide rss (eg around 4.0.x), and i wouldn't be sure it provides the same field mappings. @pmauduit ?

(i agree that those days a standalone rss service doesn't make sense with ogc-api-records doing that and much more)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for comparison, the service we still use with our 4.0.6 catalog returns this rss content: https://ids.craig.fr/geocat/srv/fre/rss.search

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants