doc change + sonar checks for stack traces

geonetwork · Oct 9, 2024 · 9209137 · 9209137
1 parent 1259263
commit 9209137
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/gn_checks.xml b/gn_checks.xml
@@ -3,7 +3,12 @@
   "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
   "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
-<!--modified for GN by adding suppression-->
+<!--modified for GN by adding suppression
+    CF https://github.com/checkstyle/checkstyle/issues/11655
+
+    Almost all of this is from
+    https://github.com/checkstyle/checkstyle/blob/checkstyle-8.29/src/main/resources/google_checks.xml
+ -->
 
 
 <!--

diff --git a/...s/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryToElastic.java b/...s/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryToElastic.java
@@ -206,7 +206,7 @@ private QueryBuilder createGeo(GnElasticInfo gnElasticInfo, String userSearchTer
           .relation(ShapeRelation.getRelationByName("intersects"));
       return geoQuery;
     } catch (IOException e) {
-      e.printStackTrace();
+      log.debug("problem constructing geoQuery - ignoring it!",e);
     }
     return null;
   }

diff --git a/...gc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryablesService.java b/...gc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryablesService.java
@@ -40,7 +40,7 @@ public JsonSchema buildQueryables(String collectionId) {
       var result = objectMapper.readValue(text, JsonSchema.class);
       return result;
     } catch (IOException e) {
-      e.printStackTrace();
+      log.debug("problem reading in Queryables - is it mal-formed?",e);
     }
 
     return null;