Skip to content

Commit

Permalink
Static pages / Fix links to load html pages content (#7203)
Browse files Browse the repository at this point in the history
* Static pages / Fix links to load html pages content.

Initialise gnActiveTbItem directive with pageId, page.pageId is not yet available when the directive is initialised.

* Pages / Ensure page is initialized before creating active-tb-item (#79)

* Pages / Ensure page is initialized before creating active-tb-item

* Pages / Add more doc about ui config

---------

Co-authored-by: François Prunayre <[email protected]>
  • Loading branch information
josegar74 and fxprunayre authored Jul 6, 2023
1 parent cdb13a8 commit 9b7bd67
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</li>
</ul>
<a
data-ng-if="!isSubmenu"
data-ng-if="!isSubmenu && page"
data-ng-show="isExternalLink"
title="{{page.label}}"
href="{{page.link}}"
Expand All @@ -45,7 +45,7 @@
<span>{{page.label}}</span>
</a>
<a
data-ng-if="!isSubmenu"
data-ng-if="!isSubmenu && page"
data-ng-show="!isExternalLink"
data-gn-active-tb-item="{{gnCfg.mods.page.appUrl + '/' + page.pageId}}?page={{page.pageId}}"
title="{{page.pageId}}"
Expand Down
2 changes: 1 addition & 1 deletion web-ui/src/main/resources/catalog/locales/en-admin.json
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,7 @@
"staticPageRemoved": "Static page removed",
"chooseStaticPageFile": "Choose or drop static page file here",
"ui-topCustomMenu": "Header custom menu items",
"ui-topCustomMenu-help": "List of static page IDs associated with the header section to display: <ul><li>When a list is provided, the links are displayed in the order provided and only for the pages listed.</li><li>When a list is not provided, all static pages configured for the header section are displayed, with no guaranteed order.</li>",
"ui-topCustomMenu-help": "List of static page IDs associated with the header section to display: <ul><li>When a list is provided, the links are displayed in the order provided and only for the pages listed.</li><li>When a list is not provided, all static pages configured for the header section are displayed, with no guaranteed order.</li>.\nPages can be inserted in between catalogue default menu which are: <pre>[\"gn-site-name-menu\",\n \"gn-portal-switcher\",\n \"gn-search-menu\",\n \"gn-map-menu\",\n \"gn-contribute-menu\",\n \"gn-admin-menu\"]</pre>. Insert a page as a simple menu using its id eg. <pre>\"documentation\"</pre> or as a submenu using an object: <pre>{\"Quick search\": [\n \"searchForAfrica\", \n \"forReview\"\n]}</pre>",
"ui-footerCustomMenu": "Footer custom menu items",
"ui-footerCustomMenu-help": "List of static page IDs associated with the footer section to display: <ul><li>When a list is provided, the links are displayed in the order provided and only for the pages listed.</li><li>When a list is not provided, all static pages configured for the footer section are displayed, with no guaranteed order.</li>",
"es.url": "ElasticSearch server",
Expand Down

0 comments on commit 9b7bd67

Please sign in to comment.