-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
kewalker
commented
Jun 8, 2022
- Bump Mobile package.
- Bump ArcGISRuntime package.
- Add UWP backgrounding support.
- Minor fixes and cleanup.
- Converts the custom Workflow component to use the new ContentComponent baseclass (with a XAML definition).
@@ -7,7 +7,7 @@ | |||
https://geocortex.com/layout/v1 ../../../layout-custom.xsd" | |||
xmlns:custom="https://geocortex/layout/samples"> | |||
|
|||
<gxm:taskbar> | |||
<gxm:taskbar orientation="vertical"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why vertical? Don't we want this to be automatic so that we get horizontal on a phone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would typically be the case, yeah. But there's an issue with the way the samples selector pushes the app such that it breaks the map view when pairing iOS with the horizontal task bar. I haven't been able to determine why that's the case. It's been this way for since these samples were crafted. But my suspicion is it's related to some of the iOS navigation stack manipulation that happens mobile side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's unfortunate. Would you be able to spend a bit of time investigating that? If you can't find a solution in a reasonable time period, then we can do the vertical orientation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've pushed a change such that iOS + phone will use PushModalAsync and inject a button so we can still return to the samples. It appears that some combination of Navigation/TabbedPage/HorizontalTaskbar/PushAsync are to blame. With that as a workaround, we're able to have horizontal task bar, so I've removed the orientation="vertical"
from some layouts.
…kbar. Remove vertical orientation from some taskbars.