Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong direction of text Y axis offset. #32

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix wrong direction of text Y axis offset. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c6ea8
Fix wrong direction of text Y axis offset.
ismailsunni May 15, 2024
7f19302
Update expected value on test..
ismailsunni May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/VectorEncoder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,8 @@ export default class VectorEncoder {
label: textStyle.getText(),
fontFamily: textStyle.getFont() ? textStyle.getFont() : 'sans-serif',
labelXOffset: textStyle.getOffsetX(),
labelYOffset: textStyle.getOffsetY(),
// OL and MFP behaves differently on the Y offset
labelYOffset: -textStyle.getOffsetY(),
labelAlign: 'cm',
} as MFPSymbolizerText;
const fillStyle = textStyle.getFill();
Expand Down
2 changes: 1 addition & 1 deletion test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const styleFn = (feature) => {
text: new Text({
text: feature.get('name'),
font: '12px sans-serif',
offsetY: 12,
offsetY: -12,
}),
image: new Circle({
fill,
Expand Down
Loading