Separate Python packages #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Sep 7, 2023
| @@ -18,7 +18,7 @@ release of the geoarrow specification. | |||
| ## Get started in Python | |||
|
|
|||
| ```python | |||
| import geoarrow.pyarrow as ga | |||
| import geoarrow.c.pyarrow as ga | |||
There was a problem hiding this comment.
This made me wonder... can you do nested namespace packages? Like I wonder if I could distribute
geoarrow.rs.core
geoarrow.rs.proj
geoarrow.rs.geos
geoarrow.rs.gdal
as four different pypi packages
There was a problem hiding this comment.
Just as a follow up, yes it works!
> tree
.
├── README.md
├── geoarrow
│ └── rs
│ └── core
│ ├── __init__.py
│ └── __pycache__
│ └── __init__.cpython-311.pyc
├── poetry.lock
└── pyproject.toml
> poetry run python
Python 3.11.4 (main, Aug 10 2023, 18:50:38) [Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import geoarrow
>>> import geoarrow.rs
>>> import geoarrow.rs.core
hello from geoarrow.rs.core
There was a problem hiding this comment.
Python is truly the wild west of packaging 🤯
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 93.56% 93.45% -0.12%
==========================================
Files 30 11 -19
Lines 5003 1527 -3476
==========================================
- Hits 4681 1427 -3254
+ Misses 322 100 -222
... and 19 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.