Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoDataset for non-extension type column (e.g., overature) #44

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

paleolimbot
Copy link
Contributor

...works with overature! (Although sort of useless since its row groups are not spatially ordered)

import geoarrow.pyarrow as ga
uri = "s3://overturemaps-us-west-2/release/2023-07-26-alpha.0/theme=admins"
ds = ga.dataset(uri, geometry_columns=["geometry"])
ds.index_fragments()

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #44 (1f8f952) into main (91d2ab9) will increase coverage by 1.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   92.44%   93.45%   +1.01%     
==========================================
  Files          25       12      -13     
  Lines        4222     1498    -2724     
  Branches       59        0      -59     
==========================================
- Hits         3903     1400    -2503     
+ Misses        286       98     -188     
+ Partials       33        0      -33     
Files Changed Coverage Δ
python/geoarrow/pyarrow/_dataset.py 99.52% <100.00%> (ø)

... and 13 files with indirect coverage changes

@paleolimbot paleolimbot merged commit c228df7 into geoarrow:main Aug 22, 2023
3 checks passed
@paleolimbot paleolimbot deleted the py-dataset-followup branch August 22, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant