Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] MapLibre layer #981

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[POC] MapLibre layer #981

wants to merge 2 commits into from

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Jul 4, 2024

I was getting a bit bored of fixing bugs, so yesterday evening I started this little thing. Absolutely not ready to go to PROD, but a good starting point for further discussion after the summer.

replaces all BG layers with a VectorTile equivalent switch to mercator as default projection to make it happen (not possible yet to mix projection systems, needs some work done on the geoblocks/ol-maplibre-layer library)

Test link

@github-actions github-actions bot changed the title [POC] MapLibre layer [POC] MapLibre layer - #minor Jul 4, 2024
Copy link

cypress bot commented Jul 4, 2024

web-mapviewer    Run #3368

Run Properties:  status check failed Failed #3368  •  git commit 1925e79b23: [POC] Support on-the-fly LV95 reprojection
Project web-mapviewer
Branch Review poc-maplibre-layer
Run status status check failed Failed #3368
Run duration 32m 30s
Commit git commit 1925e79b23: [POC] Support on-the-fly LV95 reprojection
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 129
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 34
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Tests for review

Failed  drawing.cy.js • 11 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Test Replay Screenshots
Drawing module tests > others > doesn't save an empty drawing (if not modified) Test Replay Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats Test Replay Screenshots
Drawing module tests > others > generates short links when sharing a drawing Test Replay Screenshots
Drawing module tests > others > shows a profile of a line/measure coming from service-alti data Test Replay Screenshots
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  layers.cy.js • 28 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test of layer handling > Layer in URL at app startup > starts without any visible layer added opening the app without layers URL param Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > adds a layers with config to the map when opening the app layers URL param Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > uses the default timestamp of a time enabled layer when not specified in the URL Test Replay Screenshots
Test of layer handling > Layer in URL at app startup > sets the timestamp of a layer when specified in the layers URL param Test Replay Screenshots
... > reads and adds an external WMS correctly Test Replay Screenshots
... > reads and adds an external WMTS correctly Test Replay Screenshots
... > handles errors correctly Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL, even if a layer (out of topic scope) is defined in it Test Replay Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background according to the URL param if present at startup Test Replay Screenshots
The first 10 failed tests are shown, see all 28 tests in Cypress Cloud.
Failed  importToolFile.cy.js • 3 failed tests • e2e/electron/mobile

View Output

Test Artifacts
The Import File Tool > Import KML file Test Replay Screenshots
The Import File Tool > Import KML file error handling Test Replay Screenshots
The Import File Tool > Import GPX file Test Replay Screenshots
Failed  importToolMaps.cy.js • 1 failed test • e2e/electron/mobile

View Output

Test Artifacts
The Import Maps Tool > Import external wms layers Test Replay Screenshots
Failed  legacyParamImport.cy.js • 18 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test on legacy param import > Coordinates import > transfers valid params to the hash part without changing them Test Replay Screenshots
Test on legacy param import > Coordinates import > loads correctly if params are already behind the hash Test Replay Screenshots
Test on legacy param import > Coordinates import > reproject LV95 coordinates param to EPSG:4326 Test Replay Screenshots
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV95 Test Replay Screenshots
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV03 Test Replay Screenshots
Test on legacy param import > Layers import > Combines all old layers_*** params into the new one Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy param Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers Test Replay Screenshots
The first 10 failed tests are shown, see all 18 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 29 specs in Cypress Cloud.

@pakb pakb force-pushed the poc-maplibre-layer branch from 9d4476d to ea1d620 Compare August 26, 2024 11:09
@pakb pakb force-pushed the poc-maplibre-layer branch from ea1d620 to 829e4e2 Compare September 13, 2024 08:43
replaces all BG layers with a VectorTile equivalent
switch to mercator as default projection to make it happen (not possible yet to mix projection systems, needs some work done on the geoblocks/ol-maplibre-layer library)

fix INT staging URL : no sys service serves theses styles yet
@pakb pakb force-pushed the poc-maplibre-layer branch from 829e4e2 to 016cc8b Compare September 20, 2024 07:45
@pakb pakb changed the base branch from master to develop September 20, 2024 07:46
@pakb pakb changed the title [POC] MapLibre layer - #minor [POC] MapLibre layer Sep 20, 2024
@pakb pakb force-pushed the poc-maplibre-layer branch 2 times, most recently from 9fe69a8 to 41e4b94 Compare September 20, 2024 08:03
copying geoblocks/ol-maplibre-layer/ locally to be able to edit it and add the on the fly capabilities (will create a PR there when done)

Making our coordinate system calculate resolution without threshold (especially for LV95) so that it can then be used to calculate a mercator zoom level
@pakb pakb force-pushed the poc-maplibre-layer branch from 41e4b94 to 1925e79 Compare September 20, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant