PB-326: check external provider get map #1178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerfe
force-pushed
the
feat-pb-326-check-external-provider-get-map
branch
from
62b8c22 to
67e0103
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-pb-326-check-external-provider-get-map
|
| Run status |
|
| Run duration | 05m 45s |
| Commit |
|
| Committer | Felix Sommer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
218
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
force-pushed
the
feat-pb-326-check-external-provider-get-map
branch
from
67e0103 to
a199f7c
Compare
ltshb
reviewed
Dec 19, 2024
There was a problem hiding this comment.
After a quick look at the code it looks good, however I tested it and I've got the following provider as invalid although it apparently don't support CORS:
- https://vogis.cnv.at/mapserver/mapserv?map=i_naturschutz_v_wms.map
- https://www.basemap.at/wmts/1.0.0/WMTSCapabilities.xml
I haven't checked all provider with failures, but it seems that there is a bug in the script, the first goal is to make sure the provider Get capabilities support CORS, if not no other check should be done as we can't use it in the viewer.
sommerfe
force-pushed
the
feat-pb-326-check-external-provider-get-map
branch
3 times, most recently
from
d7aa3c4 to
c971cbb
Compare
sommerfe
force-pushed
the
feat-pb-326-check-external-provider-get-map
branch
from
c971cbb to
a56f4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link