PB-1296 : remove ol-cesium shallow copy #1173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1296-remove-ol-cesium-shallow-copy
|
| Run status |
|
| Run duration | 05m 06s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
217
|
| View all changes introduced in this branch ↗︎ | |
pakb
force-pushed
the
feat-PB-1296-remove-ol-cesium-shallow-copy
branch
2 times, most recently
from
62cd6cd to
50c76bd
Compare
pakb
force-pushed
the
feat-PB-1296-remove-ol-cesium-shallow-copy
branch
from
50c76bd to
ae5545e
Compare
and get rid of the ol-cesium copy we have
gather all the logic to manage a primitive based data source into a composable and use it in the 3 cases. Adding a clampToGround option for KML layers, making it possible to have it "on top" of the terrain (it will ignore any Z value if set so). Tweaking a bit the style for Swissnames to have a buffer/offset between the ground and the text (with an anchor line/post, pointing to the ground)
pakb
force-pushed
the
feat-PB-1296-remove-ol-cesium-shallow-copy
branch
from
ae5545e to
31829f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use in-house style converter for Cesium GeoJSON and get rid of the ol-cesium copy we have
share composable between GPX, KML and GeoJSON in Cesium, gather all the logic to manage a primitive based data source into a composable and use it in the 3 cases.
Adding a clampToGround option for KML layers, making it possible to have it "on top" of the terrain (it will ignore any Z value if set so).
Tweaking a bit the style for Swissnames to have a buffer/offset between the ground and the text (with an anchor line/post, pointing to the ground)
Test link