PB-580: add warning when leaving drawing mode without export or share #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-pb-580-add-warning-leaving-drawing-mode
|
| Run status |
|
| Run duration | 05m 30s |
| Commit |
|
| Committer | Felix Sommer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
218
|
| View all changes introduced in this branch ↗︎ | |
ltshb
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Implementation looks just, just an issue regarding the store import.
Otherwise I think the warning message should be improved. @hansmannj
@Luke252 a warning about non exported drawing might be a good idea, but in my opinion the warning should say why we should export it or copy the share link. We should also differentiate if the drawing has only be shared via normal link without admin link. So if the user don't click on export and/or copy admin link the warning should say that the drawing cannot be edited anymore once the webpage is reloaded !
pakb
reviewed
Nov 11, 2024
sommerfe
force-pushed
the
feat-pb-580-add-warning-leaving-drawing-mode
branch
3 times, most recently
from
c1fa52b to
ed2c536
Compare
sommerfe
force-pushed
the
feat-pb-580-add-warning-leaving-drawing-mode
branch
3 times, most recently
from
e090bda to
3656acb
Compare
sommerfe
force-pushed
the
feat-pb-580-add-warning-leaving-drawing-mode
branch
from
3656acb to
3cea793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link