PB-790: Update mapfishprint to include fix for empty text on annotation. - #patch #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Passing run #3021 ↗︎
Details:
Review all test suite changes for PR #1011 ↗︎ |
|||||||||||||||
ltshb
requested changes
Aug 7, 2024
| @@ -39,7 +39,7 @@ | |||
| "@fortawesome/free-solid-svg-icons": "^6.5.2", | |||
| "@fortawesome/vue-fontawesome": "^3.0.8", | |||
| "@geoblocks/cesium-compass": "^0.5.0", | |||
| "@geoblocks/mapfishprint": "^0.2.14", | |||
| "@geoblocks/mapfishprint": "github:geoblocks/mapfishprint#932253b0e8ccc0c1d911cab8e02c5b2fc7a061af", | |||
There was a problem hiding this comment.
Would be much better to wait and have a proper release tag here to go to prod (merging this PR will push it directly to prod !)
|
@ltshb yes, that's what I mean with my comment in the PR description. But after I read it again, it doesn't say like that. And yes, it shouldn't be merged until we have a new version released. I tried to change it back to a draft PR, but it seems it's not possible. |
|
Superseded by #1021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE:
DO NOT MERGE this PR before a new version of mapfishprint is released.
This fix should be updated after geoblocks/mapfishprint#35 is merged and new version is released.
Test link