Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

designed and fixed UI changes #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saikiranAnnam
Copy link

What is this PR about?

  1. Redesigned the SWE site by adding components
  2. Removed one of the zoom controls (i.e previous version generated 2 zoom controls)
  3. Adjust the map bounds when the page is loaded.

Before:
Screenshot 2024-11-25 at 1 20 45 PM

Removed this zoom control on the top left:
Screenshot 2024-11-25 at 12 52 22 PM

Final Result :
Screenshot 2024-11-25 at 1 21 04 PM

@varun-TR
Copy link
Collaborator

I’ve reviewed the code, and everything looks great to me! The enhancements are well-thought-out, and I appreciate how SWE.js is used minimally, focusing mainly on setting usaBounds, while most of the tasks are handled with HTML and CSS. That’s a nice approach. As per the professor’s instructions, we’ll make sure to use Gitmojis in future PRs as well. Great job overall!

Copy link
Contributor

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants