createthumbnail improvements #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Shulyaka <[email protected]>
Signed-off-by: Denis Shulyaka <[email protected]>
Signed-off-by: Denis Shulyaka <[email protected]>
|
Hi Marco, Apparently we both modified the same things (the createthumb script). So, what are your plans for this pull requests (creating thumbnail and write cache in one path, auto detect thumb/small by size, other minor fixes)? Should I merge it with your latest commits or would you like to do it yourself? |
|
Yes, sure, I will port that |
|
@Shulyaka base it on the branch config_i18n which contains basic support for both. some stuff might be broken though, need to check. |
|
Done, please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this out, I think I've found the solution for createthumbnail to avoid any double work and code duplication