Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist AWS Secret Key when using s3 blobstore #116

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Persist AWS Secret Key when using s3 blobstore #116

merged 1 commit into from
Jan 29, 2021

Conversation

bodymindarts
Copy link
Contributor

Related: #112

@bodymindarts bodymindarts mentioned this pull request Jan 28, 2021
Open
@ramonskie ramonskie merged commit 31dd6b9 into master Jan 29, 2021
@dennisjbell
Copy link
Member

The PR does the opposite of what is needed. The prompt_for ... secret-line stuffs the value right into safe, and does not set a variable. Following this with the explicit safe set ... with uninitialized variables causes the value to be set to an empty string. This is the problem that was identified in #112 -- the fix is to remove the line that calls safe set ... (and the values that initialize the unused variables)

@ramonskie ramonskie deleted the persis-aws-secret-key-for-blobstore branch March 23, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bodymindarts @dennisjbell @ramonskie