fix: show raw storyfile import warning #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Sep 11, 2024
Comment on lines
+148
to
+150
| if (filename === except) { | ||
| return originalModule(m, filename); | ||
| } |
There was a problem hiding this comment.
Отключаем логику "если не получилось, то замокай" для основного файла - файла со сторей
Без этого получали бы на выходе мок.
Comment on lines
+83
to
+84
| if (!loggedStoryFileRequireError) { | ||
| loggedStoryFileRequireError = true; |
There was a problem hiding this comment.
Добавил тут такое условие, чтобы логов не было слишком много. Помню, такое реквестили.
KuznetsovRoman
force-pushed
the
INFRADUTY-27736
branch
from
56882d8 to
fca7230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.