Deglitcher interface for Views #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpiaggio
force-pushed
the
view-deglitcher
branch
from
038bb42 to
03d032e
Compare
|
Now this ready for review |
toddburnside
reviewed
Sep 6, 2024
| @@ -3,7 +3,6 @@ | |||
|
|
|||
| package crystal | |||
|
|
|||
| import cats.Eq | |||
There was a problem hiding this comment.
Heh. At first I read this as View Flaws Spec.
yup, working on that |
toddburnside
reviewed
Sep 6, 2024
| G.monotonic.flatMap(now => waitUntil.set(now + timeout)) | ||
|
|
||
| private def throttlerView(view: ViewF[F, A]): ViewF[F, A] = | ||
| view.withOnMod(_ => curb) // todo try to curb before modding?? maybe not necessary |
There was a problem hiding this comment.
The timeout is reset with each modification? Good.
toddburnside
approved these changes
Sep 6, 2024
|
Tests were added, and the fixes for the bugs they revealed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.