Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project reorganization + testkit #563

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Project reorganization + testkit #563

merged 1 commit into from
Nov 16, 2023

Conversation

rpiaggio
Copy link
Collaborator

Split into core+testkit+tests modules, so that we can publish the testkit.

@@ -19,7 +19,7 @@ trait EqInstances {
private[this] def arbitraryValues[A](using A: Arbitrary[A]): LazyList[A] =
LazyList.continually(A.arbitrary.sample).flatten

given viewEq[A: Eq: Arbitrary: Cogen]: Eq[ViewF[Id, A]] = Eq.instance { (v1, v2) =>
given [A: Eq: Arbitrary: Cogen]: Eq[ViewF[Id, A]] = Eq.instance { (v1, v2) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you always needed a name when having type params

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ceb657) 80.29% compared to head (c86918e) 81.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   80.29%   81.54%   +1.24%     
==========================================
  Files           5        7       +2     
  Lines         401      428      +27     
==========================================
+ Hits          322      349      +27     
  Misses         79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpiaggio rpiaggio merged commit 3135f15 into master Nov 16, 2023
9 checks passed
@rpiaggio rpiaggio deleted the testkit branch November 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants