Upgrade Komodo Package to v0.5.4 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softened theterminator line of objects in the scene.
… am commiting all my changes again to the dev-jonathan branch
Removed trusses, adjusted lightingRemoved large structures and softened lighting to nearly eliminate shadows. Type of Change
How Has This Been Tested?Visually inspect. Repaired UIManager bug, Repaired main sceneFixed menu initialization sequence. Fixed main scene by replacing the missing SocketIOAdapter and ConnectionAdapter components. Type of Change
How Has This Been Tested?Enter play mode. Expected result: menu finishes initializing and loading overlay goes away. Enter a build. Connection status window should indicate connection status info from the relay server (or a poor connection). |
|
@Barasakar When you have a chance, can you review and approve this and let me know? |
Barasakar
approved these changes
Dec 15, 2021
|
|
||
| return new Vector2(localX, localY); | ||
| } | ||
|
|
|
This addresses #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Komodo Package to v0.5.4
Cleaned up and refactored code, adjusted colors
Commented out code related to Primitives and Grouping features, which will come later. Made ImpressMenu2 panels into prefabs. Adjusted colors.
Type of Change
How Has This Been Tested?
Visually inspect menu for coloring consistency.
Repaired eraser
Fixed bug where eraser would only be enabled for the left hand.
See more details in #1
Type of change
How Has This Been Tested?
Steps to test:
Expected result: both eraser displays show up.
Added ManualTestHelper and ControllersManager
Created ManualTestHelper script and gameObject. To use it, right click the script component on the gameObject in the Main scene and select a test function.
I also introduced ControllersManager, which is a future candidate for refactoring KomodoControllerInteraction.cs. For now, it supports the
TandYkeys, which correspond to the left controller trigger and the right controller trigger. To use this, make sure the game window is focused and the menu mode is set to XR mode.Type of change
How Has This Been Tested?
See the test for "Repaired Eraser" above.
Expected result: holding
Tactivates left selection, drawing, or erasing, and holdingYactivates right selection, drawing, or erasingAdded ManualTestHelper and ControllersManager
Created ManualTestHelper script and gameObject. To use it, right click the script component on the gameObject in the Main scene and select a test function.
I also introduced ControllersManager, which is a future candidate for refactoring KomodoControllerInteraction.cs. For now, it supports the
TandYkeys, which correspond to the left controller trigger and the right controller trigger. To use this, make sure the game window is focused and the menu mode is set to XR mode.Repaired ColorPicker color selection
Color selection now reflects the correct color rather than black or white. It also works on the first opening of the draw tab, unlike before.
Under the hood, ColorPicker has been reworked into a prefab. Most functions have been moved to a static class, ColorPickerManager. The script component on the ColorImage has been reduced to the essentials. Both classes are initialized regardless of whether the draw tab is open thanks to a new script, CreateMenu.
See more details in #1
How Has This Been Tested?
See the test for "Repaired Eraser" above for how to use the VR hands in the editor on a screen.
Expected result: selecting the draw tab results in no errors, the selected color is initially white, hovering over the ColorImage results in a correct preview color, and selecting a color results in the correctly displayed color, and drawing with that color results in the correct draw stroke color.
Test Configuration
No browser yet
No VR headset yet
Checklist:
Modified from this article:
Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).