Add user-defined signal handling to freeze and warm up the Minecraft server #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some more notes: I choose to implement user signal handling in MshMgr since termination signals are handled there, so I found it fitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements feature request #270 to freeze and warm up the server using IPC with POSIX signals.
Note that this does nothing on Windows, since there isn't anything like SIGUSR1 or SIGUSR2.
I tested it in a medium-size Minecraft server and all seems to be working on Linux. (No testing done on MacOS but everything builds fine on all claimed supported OSes: Windows, Linux and MacOS).