Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: macros checks of attribute macros usages #252

Merged
merged 13 commits into from
May 20, 2024
Merged

test: macros checks of attribute macros usages #252

merged 13 commits into from
May 20, 2024

Conversation

vobradovich
Copy link
Member

Resolves #250

@vobradovich vobradovich linked an issue May 16, 2024 that may be closed by this pull request
macros: Extend checks of attribute macros usages #250
Closed
@vobradovich vobradovich requested a review from DennisInSky May 16, 2024 09:55
@vobradovich vobradovich self-assigned this May 16, 2024
@vobradovich vobradovich changed the title Vo/macros extend checks test: macros checks of attribute macros usages May 16, 2024
DennisInSky
DennisInSky reviewed May 17, 2024
View reviewed changes
macros/core/src/program.rs Outdated Show resolved Hide resolved
macros/core/src/program.rs Outdated Show resolved Hide resolved
macros/core/src/program.rs Outdated Show resolved Hide resolved
macros/core/src/shared.rs Outdated Show resolved Hide resolved
macros/core/src/shared.rs Outdated Show resolved Hide resolved
macros/core/src/service.rs Outdated Show resolved Hide resolved
macros/core/src/service.rs Outdated Show resolved Hide resolved
macros/core/src/service.rs Outdated Show resolved Hide resolved
macros/tests/ui/gservice_fails_multiple_not_allowed.stderr Outdated Show resolved Hide resolved
macros/tests/ui/gservice_fails_multiple_not_allowed_on_one_impl.stderr Outdated Show resolved Hide resolved
@vobradovich vobradovich marked this pull request as draft May 17, 2024 16:07
@vobradovich vobradovich marked this pull request as ready for review May 20, 2024 09:47
DennisInSky
DennisInSky reviewed May 20, 2024
View reviewed changes
macros/core/src/program.rs Outdated Show resolved Hide resolved
macros/core/src/service.rs Outdated Show resolved Hide resolved
macros/core/src/shared.rs Outdated Show resolved Hide resolved
macros/core/tests/program.rs Outdated Show resolved Hide resolved
@DennisInSky DennisInSky merged commit ef0d636 into master May 20, 2024
3 checks passed
@DennisInSky DennisInSky deleted the vo/macros-extend-checks branch May 20, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisInSky DennisInSky DennisInSky approved these changes

@NikVolf NikVolf Awaiting requested review from NikVolf

@holykol holykol Awaiting requested review from holykol

Assignees

@vobradovich vobradovich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macros: Extend checks of attribute macros usages
4 participants
@vobradovich @NikVolf @DennisInSky @holykol