Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metallic Bottle: use a slightly darker background color for selections #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Mar 3, 2024

I just made the background color for selections a little darker so that it is different from the foreground color.

Closes #70.

Screenshot

@eht16 eht16 added the bug label Mar 3, 2024
@eht16
Copy link
Member Author

eht16 commented Mar 28, 2024

If there are no objections or improvement suggestions, I would like to merge to this in a week.

@b4n
Copy link
Member

b4n commented Mar 29, 2024

I think the gray strings are a bit hard to read on that brown, but I have no opinion apart that the mentioned bug is indeed bad, and if this fixes it, good :)

@eht16
Copy link
Member Author

eht16 commented May 20, 2024

@b4n they are indeed.
I gave #e4d3c7 it try as a rather lighter brown than before.
Screenshot_2024-05-20_17-12-06

This might be better for selection background. Though this makes the braces and the ... in the varags of the function definition harder to read.

I'm really bad at colors :(.

@rovf since you reported it and obviously are using this theme, do you have any preference or a better alternative?

@b4n
Copy link
Member

b4n commented May 20, 2024

Better, but what about #ebdfd8?
metallic-bottle-ebdfd8

Still not great for readability, but a tad better and the whole theme doesn't focus on contrast it seems.

Not that I care, it's indeed better to get input from actual theme users 🙂

@eht16
Copy link
Member Author

eht16 commented May 20, 2024

#ebdfd8 seems fine to me.

Let's see what @rovf says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metallic Bottle Theme - foreground and background identical
2 participants