-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding marks for using lightweight markups such as txt2tags #2
base: master
Are you sure you want to change the base?
Conversation
This commit only updates 8 of 27 colour schemes and it's unclear whether you have actually tested these to see if there are any errors (looking in Debug Messages or running If I'm not confident you have tested these with various languages and checked everything is sane, and since the change adds almost as many new styles as there are existing ones, this means that in order for me to merge your changes will probably take me like a week of solid boring work just to merge changes that I'm not even sure I like as is (although I agree support for light markup languages definitively needs improvement). As it stands, I'm a little concerned about (in no particular order):
|
Here's an example of what I was hoping for using codebrainz/geany-themes@1b62107 codebrainz/geany-themes@286753a BTW, don't worry about making Git busywork, just push more commits to this PR and don't worry about clobbering my branch either. Once it's ready to go I'll squash/rebase/cherry-pick as needed for final merge. |
About testing the additions to the schemes I don't know how to do this. I hope it won't take too much of your time for mergin this. I thought it would be quite trivial because the new marks are different from the existing ones, so how could this interfere with the rest of the geany code? What I did is this:
For the missing color schemes, if you agree with what I did so far, I'll integrate the new marks in them as well. About the colors, I've most of the time used geany or gcolor2 to pick and modify them, and they only give color codes with 6 digits. |
Cool it's looking better. What do you think about my commits mentioned above, mainly removing the |
Oh, also for testing, just run Geany from the terminal like |
With
but no color related error when parsing txt2tags files. I still get "geany: Warning: ignoring null tag in ..." but it's an old bug I guess and it's not related to the new color scheme (I got this for years but it doesn't bother me) About removing I think it could be sensitive to separate lightweight markups styles and coding styles but you can choose what you prefer. It's just I already made some txt2tags color schemes for other editors such as kate or scite and I wanted them to be consistent (see for example http://wiki.txt2tags.org/index.php/Main/Scite ). To be honest I don't think there are other languages which has a preprocessor and a postprocessor, so you decide. Btw I don't need that many style names, I just need a few colors, like in the solarized them, it was enough with yellow, magenta, cyan, blue etc. |
See some screenshots there to view the new additions:
http://wiki.txt2tags.org/index.php/Main/Geany