Fix attributes starting with numeric names raise ValueError
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This update addresses an issue reported by @kmika11 in the current version of EasyDataverse, where attribute names starting with a numerical character result in a
ValueErrorraised by Pydantic, as attribute names cannot begin with a number.This PR resolves the issue by converting the initial number into a human-readable string consisting solely of alphabetic characters. Additionally, if the attribute name begins with a non-alphanumeric character (other than a letter), that character will be removed. Serialization and deserialization remain unaffected, as the original name is retained as an alias.
TLDR