Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date fields not accepting years #27

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fix date fields not accepting years #27

merged 2 commits into from
Oct 16, 2024

Conversation

JR-1991
Copy link
Member

@JR-1991 JR-1991 commented May 29, 2024

Overview

This pull request addresses the validation errors that occur when only the year is entered in a 'date' field. As there is no direct alternative that accommodates both year and complete dates, this pull request modifies the expected data type from 'date' to 'str' and delegates the validation of the actual string to Dataverse.

TLDR

  • Fix years not possible to add
  • Added test to check functionality

@JR-1991 JR-1991 added the bug Something isn't working label May 29, 2024
@JR-1991 JR-1991 self-assigned this May 29, 2024
@JR-1991 JR-1991 added this to the 0.4.2 milestone May 29, 2024
@JR-1991 JR-1991 merged commit d1543ab into main Oct 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant