Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8 adding link to dataset on success and handling parameters in language keys #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luddaniel
Copy link
Contributor

This PR includes :

UI Screenshot :
8-adding-link-to-dataset-on-success

@qqmyers
Copy link
Member

qqmyers commented Sep 13, 2023

@luddaniel - thanks for the PR. While I can see the issue that people may not read/follow the instructions and not know how to see their new files, I'm not sure that opening another copy of the dataset window is the best solution (the way things work now, the old dataset window still exists, so the user's browser would now have one view with their files and an older one without.)

Would it be good enough to make 'close this window' a link that would indeed close the window? And/or to change the text/styling to make it much clearer that 'To see your new files, 1) close this window, and 2) refresh your dataset page'.

If not, I'd like to request that the change your making be configurable (or only shown when using Dataverse <=v5.12? - since that is when refreshing the existing dataset window causes the dvwebloader to be launched again) as I think some sites will not want to have more windows popping up.

FWIW: At least parts of #8 are obsolete/only affect older versions (<=5.12) of Dataverse - with the dvwebloader integrated into the upload pane, refreshing the existing dataset window does not try to re-launch the dvwebloader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit after successful file upload
2 participants