Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watch): add button to show more content on truncated tl;dr #40

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

gdarchen
Copy link
Owner

🎯 Goal

In this PR, I added a Show more... button enabling to display the whole content on the watch resources having a truncated tl;dr.

🧠 Approach

I used a useLayoutEffect for that purpose to determine with JavaScript if the element is truncated with CSS.

I also added a title on the resource heading in case it is truncated too.

@gdarchen gdarchen self-assigned this Jul 17, 2024
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gautier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 9:55am

@gdarchen gdarchen merged commit 08af75d into main Jul 17, 2024
4 checks passed
@gdarchen gdarchen deleted the feat/show-more-watch branch July 17, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant