This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
Service worker #80
Closed
Service worker #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worker is missing a cache busting strategy and it doesn't work when the user enters the app with a query string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request has an implementation of a service worker. The goal of the pull request it to make emberaddons.com work offline and to make the site quicker by catching some dependencies in the
CacheStorage. Currently, service workers are supported in Chrome, Firefox and Opera. The pull request also fixes issue #67 .The worker implementation can be found in
ember-cli-addons-search/public/sw.jsWhat we have so far?
Currently, the service worker is installing properly and it is caching the some basic dependencies like
addons.json, the apps css and javascript uppon installation. It also filters and caches the gravatars of the addon authors. All of this dependencies are stored in theCacheStorage.What do we need?
Cache Busting Strategy - We need to figure out a cache busting strategy to update the responses stored in the cache. I think this should be managed in the
activateevent.Make service worker work with query strings in the url - Currently the service worker functions without any problems if you enter the main url but if you try to access the app with query strings in the url the service worker doesn't work.