Drop socket before client reconnect #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a client goes through a reconnect cycle, it does not drop its socket until after reconnecting. This means messages can be stuck inside the socket sink's buffer indefinitely, with their message status hanging in
MessageStatus::Sending
. To improve responsiveness, it would be better to drop the socket immediately so message statuses update promptly.Solution
ClientActor::run()
so the socket can be dropped before trying to reconnect.