Emit sink shut down reason #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
force-pushed
the
handle_sink_errors
branch
from
0413a7b to
c718dce
Compare
…e shut down reason
UkoeHB
force-pushed
the
handle_sink_errors
branch
from
c718dce to
e1b6298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sending a message to the socket may fail if the sink has shut down. Currently, this always causes clients to immediately close instead of trying to reconnect. We want the client to always have a chance to reconnect when disconnected or closed by the server.
Solution
Emit the socket sink error and update the client actor to ignore connection-related sink closure reasons. The server does not have a reconnect pattern, so we allow it to close a session if the session's socket sink shuts down.