Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
to_socket_receiver
. Normally, websocket messages that fail to send because the websocket is not connected are simply discarded. Note that there is actually a race condition inside the client actor betweenself.to_socket_receiver.recv()
andself.socket.stream.recv()
where an incoming user message will reachself.socket.send()
when the socket is disconnected even though you want the stream to capture disconnects. That means in the current code it is possible for client messages to be dropped.reconnect_interval
is anOption
but is neverNone
.Solution
reconnect_interval
so it's not anOption
.Future work