Cleanup leftover panics, downgrade errors to warnings where appropriate #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
commented
Aug 18, 2023
| @@ -276,7 +276,8 @@ pub async fn connect<E: ClientExt + 'static>( | |||
| tracing::info!("connecting to {}...", config.url); | |||
| let (stream, _) = tokio_tungstenite::connect_async(http_request).await?; | |||
| if let Err(err) = client.on_connect().await { | |||
| tracing::error!("calling `connected()` failed due to {}", err); | |||
| tracing::warn!("calling `connected()` failed due to {}", err); | |||
| return Err(err); | |||
There was a problem hiding this comment.
Now close the client if on_connect() returns an error, to be consistent with other client extension methods.
|
@gbaranski can you review this one? |
UkoeHB
force-pushed
the
acceptor_cleanup
branch
from
b4da1f2 to
1309dca
Compare
gbaranski
approved these changes
Sep 22, 2023
| @@ -264,7 +264,7 @@ where | |||
| let timestamp = Duration::from_millis(timestamp as u64); // TODO: handle overflow | |||
There was a problem hiding this comment.
I think we should handle it somehow when the timestamp isn't there.
UkoeHB
force-pushed
the
acceptor_cleanup
branch
from
1309dca to
795223e
Compare
UkoeHB
force-pushed
the
acceptor_cleanup
branch
from
795223e to
0d861ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution