Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only look for psutil if testing is enabled #1495

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Nov 5, 2024

🦟 Bug fix

Summary

This avoids an unnecessary CMake warning on builds where tests are
disabled, such as sdformat_vendor

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This avoids an unnecessary CMake warning on builds where tests are
disabled, such as [sdformat_vendor](https://github.com/gazebo-release/sdformat_vendor)

Signed-off-by: Addisu Z. Taddese <[email protected]>
@scpeters
Copy link
Member

scpeters commented Nov 5, 2024

brew CI should be fixed by gazebo-tooling/release-tools#1197

@azeey azeey enabled auto-merge (squash) November 5, 2024 21:50
@azeey azeey merged commit 9661794 into gazebosim:sdf15 Nov 6, 2024
11 checks passed
@azeey
Copy link
Collaborator Author

azeey commented Nov 26, 2024

@Mergifyio backport sdf14

Copy link
Contributor

mergify bot commented Nov 26, 2024

backport sdf14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 26, 2024
This avoids an unnecessary CMake warning on builds where tests are
disabled, such as [sdformat_vendor](https://github.com/gazebo-release/sdformat_vendor)

Signed-off-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
(cherry picked from commit 9661794)
azeey added a commit that referenced this pull request Nov 26, 2024
This avoids an unnecessary CMake warning on builds where tests are
disabled, such as [sdformat_vendor](https://github.com/gazebo-release/sdformat_vendor)

Signed-off-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
(cherry picked from commit 9661794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants