Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand SDF description on link kinematic property #1462

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Expand SDF description on link kinematic property #1462

merged 4 commits into from
Aug 2, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 23, 2024

🎉 New feature

Related PR: gazebosim/gz-physics#618

Summary

Added more documentation on what kinematic only mode means for a link. Consulted bullet / dart / ode documentation (as pointed out in gazebosim/gz-physics#618 (comment)) and extract common properties from their descriptions.

I think not all physics engine support joints between dynamic and kinematic links so I left that out in our SDF description.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested review from azeey and scpeters as code owners July 23, 2024 17:28
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 23, 2024
@iche033 iche033 mentioned this pull request Jul 23, 2024
Open
9 tasks
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
caguero
caguero requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: velcoity

@iche033
Copy link
Contributor Author

iche033 commented Jul 31, 2024

Typo: velcoity

fixed cfdd686

@iche033 iche033 merged commit 6483c25 into main Aug 2, 2024
11 checks passed
@iche033 iche033 deleted the kinematic_doc branch August 2, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏛️ ionic Gazebo Ionic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iche033 @caguero @azeey